From 484d538e3472764f0cfb7b3e55e1876c5e6e59ff Mon Sep 17 00:00:00 2001 From: Roberto Tyley Date: Thu, 28 Mar 2024 15:57:58 +0000 Subject: [PATCH 1/6] Try zulu --- .github/workflows/ci.yml | 4 ++-- .tool-versions | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e7b8566..f3e456c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,8 +18,8 @@ jobs: - name: Setup JDK uses: actions/setup-java@v4 with: - distribution: corretto - java-version: 21 + distribution: zulu + java-version-file: .tool-versions cache: sbt - name: Build and Test run: sbt -v +test diff --git a/.tool-versions b/.tool-versions index 7eb0080..2aaaeea 100644 --- a/.tool-versions +++ b/.tool-versions @@ -1 +1,2 @@ -java corretto-21.0.2.13.1 +java zulu-8.58.0.13 + From a61c8c10894ea5f524f94672cbed3ca86ab917fd Mon Sep 17 00:00:00 2001 From: Roberto Tyley Date: Thu, 28 Mar 2024 16:32:02 +0000 Subject: [PATCH 2/6] Does setup-java accept 8.58.0.13 as a Java version if it doesn't come from .tool-versions --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f3e456c..d2a9bfb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: uses: actions/setup-java@v4 with: distribution: zulu - java-version-file: .tool-versions + java-version: 8.58.0.13 cache: sbt - name: Build and Test run: sbt -v +test From 5d207aee39aa9db255e83acce5077354e349578a Mon Sep 17 00:00:00 2001 From: Roberto Tyley Date: Thu, 28 Mar 2024 16:35:33 +0000 Subject: [PATCH 3/6] Do things get better if we use 'valid semver' --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d2a9bfb..7740e93 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: uses: actions/setup-java@v4 with: distribution: zulu - java-version: 8.58.0.13 + java-version: 8.58.0 cache: sbt - name: Build and Test run: sbt -v +test From b392d36dae65b3d5f54b7c202db05d76a4f05a67 Mon Sep 17 00:00:00 2001 From: Roberto Tyley Date: Thu, 28 Mar 2024 16:50:49 +0000 Subject: [PATCH 4/6] major.minor --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7740e93..da5d85d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: uses: actions/setup-java@v4 with: distribution: zulu - java-version: 8.58.0 + java-version: 8.58 cache: sbt - name: Build and Test run: sbt -v +test From 1ba3ba48598389e6a0d014196e43374dac24f642 Mon Sep 17 00:00:00 2001 From: Roberto Tyley Date: Wed, 22 May 2024 12:14:30 +0100 Subject: [PATCH 5/6] Try SAP --- .github/workflows/ci.yml | 2 +- .tool-versions | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index da5d85d..f3e456c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: uses: actions/setup-java@v4 with: distribution: zulu - java-version: 8.58 + java-version-file: .tool-versions cache: sbt - name: Build and Test run: sbt -v +test diff --git a/.tool-versions b/.tool-versions index 2aaaeea..1808bf7 100644 --- a/.tool-versions +++ b/.tool-versions @@ -1,2 +1,2 @@ -java zulu-8.58.0.13 +java sapmachine-17.0.7-snapshot.1 From 37069826aecd572949927d8a25b665cb75f9571a Mon Sep 17 00:00:00 2001 From: Roberto Tyley Date: Wed, 22 May 2024 12:21:22 +0100 Subject: [PATCH 6/6] Try temurin --- .tool-versions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.tool-versions b/.tool-versions index 1808bf7..1d57eed 100644 --- a/.tool-versions +++ b/.tool-versions @@ -1,2 +1,2 @@ -java sapmachine-17.0.7-snapshot.1 +java temurin-17.0.4+101