Pumpify "premature close" fix #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erikkemperman @terinjokes What do you guys think of this fix? It seems to fix my pumpify issue while keeping the anti-Promise-swallowing test passing. |
|
Also, I linked it into https://github.com/cristianl/testcase-vinyl-bug and I see the actual error (ENOENT from fs-mkdirp-stream) instead of "Premature close" |
phated
changed the title
|
@phated That sounds like the proper fix here! Sorry I've been quiet, slightly insanely swamped at the moment... |
stephenlacy
approved these changes
Jan 15, 2018
|
LGTM
…On Jan 15, 2018 1:45 PM, "Steve Lacy" ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQsZefIcywicTWc3y_SDXAehlqDcSIfks5tK8b-gaJpZM4RdhZ9>
.
|
|
Thanks all. I shipped this as 1.2.4 - now if only people would get it (have I mentioned how much I hate package-lock.json?) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@erikkemperman I'd love another pair of eyes on this to try to get it fixed correctly.