Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test fail on the latest version #2801

Open
rluvaton opened this issue May 2, 2024 · 3 comments
Open

Test fail on the latest version #2801

rluvaton opened this issue May 2, 2024 · 3 comments

Comments

@rluvaton
Copy link

rluvaton commented May 2, 2024

Running the citgm on gulp in node 22 fail


verbose: gulp npm-test:      |                     
verbose: gulp npm-test:      | 41 passing (9s)     
verbose:                     | 1 failing           
verbose: gulp npm-test:      | 1) gulp                                                                                                                         
verbose:                     | can run against gulpfile.mjs:                                                                                                   
verbose:                     | Uncaught Error: expect(received).toEqual(expected) // deep equality                                                             
verbose:                     |                                                                                                                                 
verbose:                     | Expected: ""                                                                                                                    
verbose:                     | Received: "(node:2245619) Warning: To load an ES module, set \"type\": \"module\" in the package.json or use the .mjs extension.
verbose:                     | (Use `node --trace-warnings ...` to show where the warning was created)                                                         
verbose:                     | "                                                                                                                               
verbose:                     | at /home/iojs/tmp/citgm_tmp/4e153d52-d0e6-4ff1-8743-1304b717ff4a/gulp/test/index.test.js:90:22                                  
verbose:                     | at ChildProcess.exithandler (node:child_process:413:7)                                                                          
verbose:                     | at FastEventEmitter.emit (node:internal/events/fast_event_emitter:47:26)                                                        
verbose:                     | at ChildProcess.emit (node:internal/events/event_emitter:448:41)                                                                
verbose:                     | at ChildProcess.emit (node:domain:488:12)                                                                                       
verbose:                     | at maybeClose (node:internal/child_process:1105:16)                                                                             
verbose:                     | at ChildProcess._handle.onexit (node:internal/child_process:305:5) 

@yocontra can you please take a look

@yocontra
Copy link
Member

yocontra commented May 3, 2024

What version of node was this run on specifically? And I'm assuming gulp v5?

@phated
Copy link
Member

phated commented May 4, 2024

Gulp tests are mostly smoke tests. Node has removed the vinyl-fs test suite from citgm (and probably other of our projects) and broke it completely with node 22.

@rluvaton
Copy link
Author

rluvaton commented May 5, 2024

master version of node, can probably reproduce with node 22

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants