Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat!: Populate additional preload modules with configFiles #131

Merged
merged 2 commits into from
Mar 16, 2024
Merged

feat!: Populate additional preload modules with configFiles #131

merged 2 commits into from
Mar 16, 2024

Conversation

phated
Copy link
Member

@phated phated commented Mar 16, 2024

As per @sttk requested in #128, this adds preloads to the env if they exist in the config.

@phated phated requested a review from sttk March 16, 2024 03:54
@phated phated mentioned this pull request Mar 16, 2024
Merged
sttk
sttk reviewed Mar 16, 2024
View reviewed changes
Copy link
Contributor

@sttk sttk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phated Good work! I've made one minor suggestion, but other than that, everything looks fine.

@phated phated merged commit fad21a9 into main Mar 16, 2024
15 checks passed
@phated phated deleted the phated/config-preloads branch March 16, 2024 22:34
@github-actions github-actions bot mentioned this pull request Mar 16, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sttk sttk sttk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phated @sttk