-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix!: Use SHA-256 for the config file name #57
Conversation
Fixed a maximum line length eslint warning on this line as well. This change doubles the length of the file name from a previous 32 hex characters to 64. Fixes: gulpjs#56
One thing that we need to be conscious of for this is that the increase in filename length might cause Windows systems to fail with a max filepath limit. We might want to release this as a breaking change due to that ☝️ |
Indeed, thought I do consider it unlikely we'll reach
which is around 135 chars + length of the username, so should be well within that limit. |
Bump, I could really use this fix in a project. It is breaking the project when enforcing FIPS when enforcing FIPS because MD5 is not FIPS compliant @silverwind @phated |
This comment has been minimized.
This comment has been minimized.
@Shawn1874 As with all open source, it'll get done when it gets done. It wasn't until recently that gulp started to have any significant sponsors since all funding disappeared since covid. |
This comment has been minimized.
This comment has been minimized.
Thanks for this @silverwind! Sorry for the delay, but wanted to include this in the next major in case it breaks someone. |
Fixed a maximum line length eslint warning on this line as well. This change doubles the length of the file name from a previous 32 hex characters to 64.
SHA-256 was added in OpenSSL 0.9.8, released 2005-06-06, so every Node.js version should have it.
Fixes #56