Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix extension of class properties #1

Closed
wants to merge 4 commits into from
Closed

Fix extension of class properties #1

wants to merge 4 commits into from

Conversation

json-derulo
Copy link

Fixes gund#25

@json-derulo
Copy link
Author

@Delagen would be great if you could review this :)

@Delagen
Copy link
Owner

Delagen commented Dec 9, 2021

@json-derulo partially merged via 4a87a42. Thanks.

@Delagen Delagen closed this Dec 9, 2021
@Delagen
Copy link
Owner

Delagen commented Dec 9, 2021

Published in npm as 1.3.1

@json-derulo
Copy link
Author

json-derulo commented Dec 9, 2021

@Delagen thanks for merging this. However, as I just found out in a real project of mine, now the wrong function signature is used, which brought up a lot of new false positive errors. Unfortunately, there are currently no test cases covering this.

Could you revert the changes of this PR and publish a new version?

I will add additional test cases for the new errors, and will try to fix the issue in the meantime. I'm very sorry for this.

@json-derulo
Copy link
Author

The variable assignment I removed seems to be necessary sometimes. I had no luck so far finding out, which is the right condition to do the assignment. Will continue tomorrow.

@json-derulo json-derulo deleted the fix-class-property-extend branch December 9, 2021 17:40
@Delagen
Copy link
Owner

Delagen commented Dec 9, 2021

reverted, some deps updates, 1.3.2

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positive error when extending a deprecated method
2 participants