Are GUIComponents X and Y ignored by Render()?

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2019-12-06 11:22:06
User: KvaGram [] (age: 1068 days 🔥; posts: 52)}
So, I'm building a grapical element here.
For now I use RoundRect (planning on adding images later).
@Override public void render(Graphics2D g) { super.render(g); if (!loc.isValidSection()) return; g.setStroke(new BasicStroke(1)); g.setColor(new Color(186, 190, 180)); g.fillRoundRect((int)getX() + 5, (int)getY() + 5, (int)getWidth()-5, (int)getHeight()-5, 10, 10); g.setColor(new Color(61, 58, 50)); g.setStroke(new BasicStroke(4)); g.drawRoundRect((int)getX() + 5, (int)getY() + 5, (int)getWidth()-4, (int)getHeight()-4, 10, 10); }
Am I doing it wrong? It seems a bit cumbersome to have to cast the X and Y to int and then add them to the draw and fill commands.

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2019-12-08 10:12:54
User: nightm4re [Admin 👑, Mod 🔧] (age: 1567 days 🔥; posts: 185)}
Since there is only one ~~~~Graphics2D object being passed to all GUIComponents for rendering, you will have to specify the exact "global" location of what you're trying to draw. So yes, drawing doesn't happen relatively, the local coordinates are ignored.
Also, have a look at the ~~~~~~~~ShapeRenderer, which provides a unified API for drawing and filling shapes, similarly to the ~~~~ImageRenderer or ~~~~TextRenderer.

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2019-12-08 10:21:51
User: KvaGram [] (age: 1068 days 🔥; posts: 52)}
Thanks. I will look into that. Yet what you are saying dosen't sit quite right with me.
I prototyped my game in Swing before this (Yes, really).
Now, being new to Java, it is hard to know where AWT ends and Swing begins, but the swing components all had their own Graphics2D instance.
I'm gonna dig in those source files again and see if I can find that again.

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2019-12-08 10:33:04
User: KvaGram [] (age: 1068 days 🔥; posts: 52)}
Some magic are indeed happening in
swing.JComponent.java public void paint(Graphics g)
Too bad that sourcecode I got only have javadoc, and no inline comments explaining it all.
In any case, looking at awt.Graphics.Java functions create() and create (int x, int y, int width, int height),
I think standard practice for child components would be to run Graphics.create on the Graphics instance passed from their parents.
I recommend you test that out that in the engine, putting it at the first line in de.gurkenlabs.litiengine.gui.GuiComponent.java public void render(final Graphics2D g)

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2019-12-08 10:43:39
User: KvaGram [] (age: 1068 days 🔥; posts: 52)}
And by that, I think it prudent to add an "suggestions" tag to this thread.
Not sure how, or even if, I can do that myself on this forum.

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2019-12-08 21:54:12
User: nightm4re [Admin 👑, Mod 🔧] (age: 1567 days 🔥; posts: 185)}
To me, copying the parent Graphics2D object for every GUIComponent sounds like quite some amount of overhead.
Nevertheless, we should investigate this.

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2020-01-05 21:03:35
User: KvaGram [] (age: 1068 days 🔥; posts: 52)}
This subject suddenly ended up back in my mind today, so I decided to ask Stack Overflow for you.
The comments I have gotten so far do say something.
https://stackoverflow.com/questions/59603939/is-it-better-to-reuse-the-same-instance-of-awt-graphics-than-to-create-copies-wi

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2020-01-07 09:15:28
User: nightm4re [Admin 👑, Mod 🔧] (age: 1567 days 🔥; posts: 185)}
What are the conclusions you draw from the answers?
Either I haven't fully understood the explanations, or all they are saying is "it depends", meaning there is no wrong or right approach for this subject.

[nightm4re94]

^{This post has been migrated automatically from the old LITIENGINE forum (2018 - 2022).
Posted: 2020-01-07 09:34:14
User: KvaGram [] (age: 1068 days 🔥; posts: 52)}
The conclusions I draw, is that you should follow the advice MadProgrammer gives.
To use the pattern of "create/dispose" for UI components.
I checked the source-codes for swing to confirm that pattern is used there, and it is.
Since awt.Graphics is implemented in the jre, we can't check code to be sure.
But if we take MadProgrammer on his word, there should be no issue.
From what I understand, an instance of Graphics only stores the drawing area, drawing location, font, etc type of information. The type of data you'd want to reset anyway when drawing a different type of object.
I suppose you could go for a hybrid solution. I don't know how your tile-system works, but I imagine there are a lot of tiny objects there all drawn with more or less the same settings, right? Well, in that case, you might not need a new instance of Graphics for every single tile.
But again, there is one thing I have heard over any over from some of my peers. Don't optimize prematurely. Optimize when needed instead. A lesson I am still learning myself, but I find it prudent to share it here regardless.