fix(form-core): creation of form group mutating members array

gutentag2012 · Jun 17, 2024 · e5432e0 · e5432e0
1 parent 56b4baa
commit e5432e0
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 4 deletions.
diff --git a/packages/form-core/src/FormLogic.spec.ts b/packages/form-core/src/FormLogic.spec.ts
@@ -759,6 +759,19 @@ describe('FormLogic', () => {
       group.unmount()
       expect(form.fieldGroups.value).toEqual([])
     })
+    it("should not mutate the passed members array when creating a field group", () => {
+      const members = ['start', 'end'] as ["start", "end"]
+      const form = new FormLogic({
+        defaultValues: {
+          start: 0,
+          end: 1,
+        },
+      })
+      form.mount()
+
+      form.getOrCreateFieldGroup(members)
+      expect(members).toEqual(['start', 'end'])
+    })
   })
   describe('validation', () => {
     it('should trigger submit validation for all fields on submit as well as the form', async () => {

diff --git a/packages/form-core/src/FormLogic.ts b/packages/form-core/src/FormLogic.ts
@@ -35,7 +35,7 @@ import {
   unSignalifyValueSubscribed,
 } from './utils'
 import { deepCopy } from './utils/access.utils'
-import { Truthy } from './utils/internal.utils'
+import {getGroupKey, Truthy} from './utils/internal.utils'
 import type { ConnectPath, ExcludeAll, KeepOptionalKeys } from './utils/types'
 import {
   clearErrorMap,
@@ -827,7 +827,7 @@ export class FormLogic<
       TMixin
     >,
   ): FieldGroupLogic<TData, TMembers, TGroupAdapter, TAdapter, TMixin> {
-    const groupKey = members.sort().join('-')
+    const groupKey = getGroupKey(members)
     const existingGroup = this._fieldGroups.value.get(groupKey) as
       | FieldGroupLogic<TData, TMembers, TGroupAdapter, TAdapter, TMixin>
       | undefined
@@ -856,7 +856,7 @@ export class FormLogic<
     members: TMembers,
     group: FieldGroupLogic<TData, TMembers, TGroupAdapter, TAdapter, TMixin>,
   ): void {
-    const groupKey = members.sort().join('-')
+    const groupKey = getGroupKey(members)
     if (this._fieldGroups.peek().has(groupKey)) return
 
     const newMap = new Map(this._fieldGroups.peek())
@@ -867,7 +867,7 @@ export class FormLogic<
   public unregisterFieldGroup<TMembers extends Paths<TData>[]>(
     members: TMembers,
   ): void {
-    const groupKey = members.sort().join('-')
+    const groupKey = getGroupKey(members)
     if (!this._fieldGroups.peek().has(groupKey)) return
 
     const newMap = new Map(this._fieldGroups.peek())

diff --git a/packages/form-core/src/utils/internal.utils.ts b/packages/form-core/src/utils/internal.utils.ts
@@ -3,3 +3,7 @@ export function Truthy<T>(
 ): value is NonNullable<T> {
   return !!value
 }
+
+export function getGroupKey(members: string[]) {
+  return [...members].sort().join('.')
+}