snr_IFO labels in PyGRB

[pannarale]

https://github.com/gwastro/pycbc/blob/master/pycbc/events/eventmgr.py#L710 causes individual detector SNR labels to end with '1' only when the IFO in question is LHO. In turn, all pygrb post-processing that uses individual detector SNR information has to adapt to this convention: basically an if ifo == 'H1' ends up being needed in several places, which is not ideal. Better switch to a consistent naming: 'snr_h1', 'snr_l1', 'snr_v1', 'snr_k1'.

[pannarale]

Speaking of ugly PyGRB labels, here is more: https://github.com/gwastro/pycbc/blob/master/bin/pycbc_multi_inspiral#L269 and https://github.com/gwastro/pycbc/blob/master/bin/pycbc_multi_inspiral#L280 (affects pycbc_pygrb_plot_chisq_veto)

[titodalcanton]

@pannarale I do not understand your second comment as I think the code has changed in the mean time. What were the other ugly labels?

[titodalcanton]

The snr_* field names have now been fixed in #4639.

[pannarale]

@titodalcanton, yes that PR fixes precisely the issues I used to refer to here. As you note there will be a need for fixes downstream once we feed pycbc_multi_inspiral output to the post processing scripts.