Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Be efficient with imports #4783

Open
GarethCabournDavies opened this issue Jun 12, 2024 · 2 comments
Open

Be efficient with imports #4783

GarethCabournDavies opened this issue Jun 12, 2024 · 2 comments

Comments

@GarethCabournDavies
Copy link
Contributor

Sometimes the whole package isnt needed, so we can use e.g. from pycbc import init_logging.

We should also check what is being imported when, I cant remember exactly where, but the other day I got an error to do with the neutron star equation of state when trying to import an argument parser group

@GarethCabournDavies
Copy link
Contributor Author

helped by #5002

@titodalcanton
Copy link
Contributor

I think we still have several cases of from xyz import *, especially in the tests, which is probably not a good idea.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants