Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename remove_nan_layers to 'remove_inactive_layers' or 'remove_zero_thickness_layers' #300

Open
bdestombe opened this issue Nov 27, 2023 · 0 comments

Comments

@bdestombe
Copy link
Collaborator

          we should probably rename this to 'remove_inactive_layers' or 'remove_zero_thickness_layers'.

With the move to internally always assume modflow-style layer models (with one top and N bottoms), renaming this kwarg would make it more clear what we're doing.

We do need to maintain some backward compatibility though, so we should add the new name and throw a DeprecationWarning for the old one. Up to you whether you open a new issue for this or add it as part of this PR :).

Originally posted by @dbrakenhoff in #295 (comment)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant