Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

calculate_resistance calculates resistance between layers #310

Open
rubencalje opened this issue Dec 27, 2023 · 2 comments
Open

calculate_resistance calculates resistance between layers #310

rubencalje opened this issue Dec 27, 2023 · 2 comments

Comments

@rubencalje
Copy link
Collaborator

rubencalje commented Dec 27, 2023

Right now calculate_resistance calculates the resistance between layers (also see issue #134), and not the resistance of layers themselves (if that is correct english...).

I propose to rename the current calculate_resistance to calculate_resistance_between_layers, and create a new calculate_reistance with the formula:

c = nlmod.layers.calculate_thickness(ds) / ds['kv'].

Any objections?

@rubencalje
Copy link
Collaborator Author

Or add an optional argument to calculate_resistance named between_layers, which is set to False by default (which would change the current outcome of calculate_resistance). I prefer this option.

@OnnoEbbens
Copy link
Collaborator

Or add an optional argument to calculate_resistance named between_layers, which is set to False by default (which would change the current outcome of calculate_resistance). I prefer this option.

I also prefer this option

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants