Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add jarvis to AllFeaturizers #144

Closed
ardunn opened this issue Dec 8, 2018 · 1 comment
Closed

Add jarvis to AllFeaturizers #144

ardunn opened this issue Dec 8, 2018 · 1 comment
Assignees
@ardunn

Comments

@ardunn
Copy link
Contributor

ardunn commented Dec 8, 2018

Jarvis descriptors are for structure features and are not super-expensive to compute. Once hackingmaterials/matminer#342 is merged, Jarvis should be added to the StructureFeaturizers.best
@ardunn ardunn self-assigned this Dec 8, 2018
@ardunn
Copy link
Contributor Author

ardunn commented Dec 11, 2018

Only after the JARVIS pull request is merged on matminer.

This should be done by adding JARVIS to the AllFeaturizers StructureFeaturizers.best or at least StructureFeaturizers.all

@ardunn ardunn added the ugrads label Dec 11, 2018
@ardunn ardunn closed this as completed Dec 20, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ardunn ardunn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ardunn