Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

setup.py imports automatminer #202

Closed
utf opened this issue Mar 28, 2019 · 2 comments
Closed

setup.py imports automatminer #202

utf opened this issue Mar 28, 2019 · 2 comments

Comments

@utf
Copy link
Member

utf commented Mar 28, 2019

setup.py import automatminer. If automatminer has not be installed before, then this step can fail.

@ardunn ardunn mentioned this issue Mar 28, 2019
@utf utf closed this as completed Mar 28, 2019
@ardunn
Copy link
Contributor

ardunn commented Mar 28, 2019

@utf weird that this is happening, did it throw error for you?

i changed it regardless but still

In the python docs they reference it as a legitimate method of single-source versioning but with a warning. i haven't run into any problems with it but still

https://packaging.python.org/guides/single-sourcing-package-version/

@utf
Copy link
Member Author

utf commented Mar 28, 2019

The reason why this failed and that the example works, is because we are importing other things in the root __init__.py file. So I was getting an error that xgboost wasn't installed when I was trying to pip install automatminer to install the new dependencies.

You could use your old method for versioning, provided import automatminer doesn't import any external packages.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants