-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Keyword arg for predicted column name #266
Comments
Hey @janosh I'd accept a PR to make it configurable! I think this should take form in two parts: (2) a powerup kwarg to the get_preset_config for MatPipe.from_preset method. |
Are you sure this should be part of |
Yes, in the sense it should be a powerup (kwarg), not a preset itself. The "powerups" are intended to be common options that are applied to the pre-defined presets. The idea is that if you want to enable some common options while using a preset (e.g., cache the features in some file, set the number of jobs, etc.) you don't need to specify an entire custom pipeline for MatPipe. For example, So without making it a powerup, if you wanted to set the output col name, you'd need to either define and entire custom pipeline (bad, lots of work [relatively]) or get the preset config and then replace the AutoFeaturizer with a custom one (less bad, but still not intuitive). Making it a powerup in
|
I see what you mean. I'll add that. |
The default name
target + " predicted"
for the new column appended to a dataframe bymat_pipe.predict()
contains a space and prevents the use of dot notation to access the column. Would you accept a PR to make this suffix configurable or maybe even change the default totarget + _predicted"
ortarget + _pred"
?The text was updated successfully, but these errors were encountered: