Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

zhou gaps formula can't be converted to composition #38

Closed
ardunn opened this issue Jul 22, 2018 · 2 comments
Closed

zhou gaps formula can't be converted to composition #38

ardunn opened this issue Jul 22, 2018 · 2 comments

Comments

@ardunn
Copy link
Contributor

ardunn commented Jul 22, 2018

I think this is a problem with only one of the formulas, but when I do:

df = load_expt_gap()
df['composition'] = [Composition(f) for f in df['formula']]

I get the error:

CompositionError: ,65 is an invalid formula!
@albalu albalu mentioned this issue Jul 22, 2018
Merged
@albalu
Copy link
Contributor

albalu commented Jul 22, 2018

Thanks @ardunn for noticing it. I contacted the author too but for the time being dropped those formulas. #39 fixes this issue.

@ardunn
Copy link
Contributor Author

ardunn commented Jul 22, 2018

Perfect thanks :)

@albalu albalu closed this as completed Jul 22, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albalu @ardunn