Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Failures in Voronoi Tessellations #266

Closed
WardLT opened this issue Jul 4, 2018 · 4 comments
Closed

Failures in Voronoi Tessellations #266

WardLT opened this issue Jul 4, 2018 · 4 comments

Comments

@WardLT
Copy link
Contributor

WardLT commented Jul 4, 2018

The Voronoi-tessellation-based featurizers all have a minor error rate due to problematic structures failing to tessellate.

As an example, mp-623782 fails to tessellate due to an error running qhull.

There are a few possible routes we could take to trying to lower the error rate:

  1. Making sure our cutoff for Voronoi tessellations is large enough to capture all NNs
  2. Perturbing the unit cell and re-attempting the tessellation (suggestion from Bryce Meredig).

If these don't work, we should at least report actionable error messages (e.g., "tessellation failed, consider removing this entry from the dataset or turning on ignore_errors)

@computron
Copy link
Contributor

I just created a PR in the VoronoiNN class in pymatgen to fix the cutoff issue:

materialsproject/pymatgen#1193

When merged, this should fix problems for some structures but I don't think it will fix mp-623782. I tried perturbing mp-623782 but that didn't seem to fix the problem, so I didn't implement that strategy. There might be something more fundamental going on in either qhull or the pymatgen wrapper causing the problem.

@computron
Copy link
Contributor

I also just pushed a commit to help guide users to setting ignore_errors=T:

483bdaf

@utf
Copy link
Member

utf commented Sep 27, 2018

Hopefully this should be fixed by materialsproject/pymatgen#1289.

@computron
Copy link
Contributor

I am going to close this for now as I think we've solved it as much as we plan to at the moment. If someone sees this re-appearing please feel free to re-open.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants