Travis reports failing builds as passing

[jaronheard]

Description

When make deploy fails for one of the deploy targets, Travis still reports passes - this is how #536 and #471 were introduced without being caught.

Steps to reproduce

View logs for current master build for SUITE:2018 and SUITE:COMPONENT-LIBRARY here:
https://travis-ci.org/hackoregon/civic/builds/532668460

Observe under make deploy (expand section near bottom of log) that it is failing as described in #536 and #471, but that Travis is reporting a pass

Expected result

Travis should report a failure

Actual result

See above

More context on how to fix

Our build system right now is a bit of a hack, to work around the parts of Travis that used to cost money. Not that those items are free, we should fix this by making our build system use Travis build stages rather than hiding everything in after-success.

• https://docs.travis-ci.com/user/conditional-builds-stages-jobs/
• looks like build stages are free now?
• as well as conditional branches??