-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open new ticket via email #28
Comments
I'm happy taking this bundle in new directions, as long as they are optional (via config). If you send me a PR I'm very likely to accept it. |
The TicketManager was added a while ago, so this would be straight forward to add as to an additional project. Receiving email within this bundle would be too bespoke. |
@dmecke , @hackzilla ... in my opinion this optional feature would be fantastic... |
The TicketBundle allows anyone to create tickets and messages using the TicketManager.
The only bit missing would be the reading of the email messages and figuring out what to do with them. I could write a guide of how I'd create a bot for Telegram.me, that anyone could adapt to email, or any other system. |
@hackzilla , yes... a bot for telegram would be interesting too! |
@hackzilla I thought about the possibility to add more systems, in particular imap/pop3. This feature can be disabled by default and enabled with a setting, the same as others system (telegram, facebook, ...). |
Hi! |
@Filoz I have updated the doc and pushed a feature branch to my fork I add the notification bundle from https://github.com/flodaq/TicketNotificationBundle as a feature (with is approval :) ) and add a "ticket from mail" feature. You need to have notification feature enabled to use the ticket from mail, because I rely on is mailer (to avoid code duplication, and speed up the dev) I will test it on my preprod today, feel free to report any trouble, I may not have thinking about everything. @hackzilla I am not familiar with this, but can you open a feature branch, to merge this one, so we can use it with composer on packagist to beta test ? Thanks |
You can add this to your composer.json to override the repository.
Then you will be able to put
That way you still have control of the branch, without needing me to pull changes. |
Wow, it looks very promising! I gave a fast look the the source and it looks ok! From the doc should be pointed out that is both possible to create a new ticket and reply an existing ticket from email. Maybe a good feature is to add 2 option:
because sometime you want that only logged user can open new ticket so open a ticket by email should be disabled and must return an email like 'To create a new ticket please go to htt....' In the email I think that would be better to add a random (and unique) code (referring to the ticket) instead the id, otherwise someone can reply to a different ticket simply changing the id in the email. This part should be changed https://github.com/nicolas-san/TicketBundle/blob/feature_notification_and_ticket_from_mail/Command/TicketFromMailCommand.php#L63 . the last thing IMHO should be added is a flag that specify if the ticket/reply was added by email or not, because can be useful to know where a given ticket comes from.
(the name should be improved :) ) and it's value can be 'web' if it is created from the ticketing pages, 'email' from email, 'telephone' (can be a future extension, the admin opens a ticket and set the author)... |
Thank you for your message. ? |
Yes, this is a very good solution! |
@Filoz We shouldn't need to modify the base entity. I added something called "Features", to describe the database changes required. |
I push today my production ready code. @hackzilla would you merge my branch into the main project ? Would you review and test it first (you should :) ) ? |
Hey @nicolas-san, thanks for doing this. I'm of 2 minds of whether this should be in the TicketBundle, or a separate bundle.. (Like TicketNotificationBundle) Currently I'm working on #109, my head is currently thinking through that, as I'm trying to sort out #110 In terms of following my architecture, the only thing I was would change, is the entity. |
Is it an issue for you if I fork ? (I know I can, but I prefer ask your feeling about before I do) I can understand if don't want to merge, and If you won't I will continue modifying it to suit my needs but with more liberty to change core things. |
I wasn't saying no. Currently I'm maintaining 2 versions of the ticket bundle, and there is likely to be another when symfony v4 is out. So I've trying to split out the functionality of the tickets, and just leave the framework implementation. I'm happy to help you after this to turn your branch into a library which uses TicketBundle. |
My first goal was to add functionalities and merge :) I can't see precisely what I have to do after your work on the library. |
I'm going to pull in your work, but It'll be part of #109 (which will become v4). |
I'm currently looking at this.
@nicolas-san Is this a email blacklist? |
Yes something like that, I use it to manage some specials emails from some users. |
First, thanks for sharing this bundle!
I would like to know if you are planning / accepting a pull request to add support for creating new tickets via incoming emails. So customers could send an email to support@acme.com and a new ticket is opened automatically and answers are sent back to the customers email.
The text was updated successfully, but these errors were encountered: