Pre-1.4.0 Discussion

[RobertD502]

@gdgib
Just starting a thread with you to discuss some ideas about possible changes and to get your thoughts on it. I'll use this discussion as sort of a list to which I'll add to as I go through the code.

1. Removing the update devices service call: With the rework of the config flow and the ability to reload the config, keeping this custom service call doesn't make any sense. If a user has Home Assistant running and they add a new device to their VeSync account, simply reloading the config from the Home Assistant UI accomplishes the same thing as the new device will be present in the coordinator and platforms will get reloaded. Having this service call also seems to be confusing users and leading them to think that the service call can magically make their device function with the integration.
2. Setting the auto mode switch to off should only set the humidifier to manual mode and not also change the mist level to 1: It would be worthwhile keeping this as users can use a switch such as this to control the mode from within HomeKit (Can't control mode of a humidifier entity from within HomeKit). However, the current behavior of it changing the mist level to 1 when the switch is turned off isn't something users would naturally expect, and it isn't documented.

[gdgib]

100% agree on both. Let me know if you're going to tackle them or want me to.

[RobertD502]

I have no problem tackling them while I'm already going through and making some fixes for the things I previously mentioned.

[gdgib]

Sounds good. I'll leave this in your hands for now then.

[neilmartin83]

Just wanted to add a note of huge thanks for picking up on this integration. Python is not my bag so I'm useless when it comes to any dev work but I just wanted to share my appreciation.

I rely on automating the air purifier night lights which aren't part of the official HA integration. I'm incredibly grateful for all the work that's been put in to this by people giving up their spare time for free. It makes a big positive difference to a lot of people's lives including mine.

❤️