Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improved handling of multiple and big diagrams #109

Closed
hallvard opened this issue May 16, 2020 · 0 comments
Closed

Improved handling of multiple and big diagrams #109

hallvard opened this issue May 16, 2020 · 0 comments
Milestone

Comments

@hallvard
Copy link
Owner

Today's design only allows a DiagramTextProvider to contribute one diagram and will need to produce it completely. It can neither contribute several (alternative) diagrams or do it lazily. There is a need to separate the contribution of the actual diagram from the ability/intention to contribute one or more diagrams (and allow the user to select which).

The current idea is to introduce a DiagramInfo object with information about a diagram that may be provided, with methods for getting meta-data about the diagram and the actual diagram text. This allows the diagram to be computed lazily. Another interface DiagramInfoProvider and corresponding extension will allow to provide a collection of DiagramInfo objects for a specific editor and selection. The old DiagramTextProvider can be wrapped in a DiagramInfoProvider to support existing extensions.

If several diagrams (or DiagramInfo) objects are available, one can be provided by default (perhaps based on priority) and the user should be able to select an alternative one. The DiagramInfo object should contain enough meta-data to give a good UX, e.g. label text and/or icon.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant