Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

updateConfig() should check if new config is the same as the old one #1251

Closed
sequba opened this issue Apr 25, 2023 · 1 comment · Fixed by #1256
Closed

updateConfig() should check if new config is the same as the old one #1251

sequba opened this issue Apr 25, 2023 · 1 comment · Fixed by #1256
Labels
Feature Something we can add later on without introducing a breaking change Impact: Low

Comments

@sequba
Copy link
Contributor

sequba commented Apr 25, 2023 •
edited
Loading

Description

updateConfig() is an expensive operation. It rebuilds the whole engine so we should avoid doing it when not necessary. This method should check if the new config is the same as the old one.

Links

handsontable/handsontable#10326
#1252
@sequba sequba added Feature Something we can add later on without introducing a breaking change Impact: Low labels Apr 25, 2023
@sequba sequba mentioned this issue Apr 25, 2023
Open
@sequba sequba linked a pull request Apr 27, 2023 that will close this issue
Make updateConfig rebuild the engine only when new config is different from the old one #1256
Merged
13 tasks
This was referenced Apr 27, 2023
Merged
Merged
@AMBudnik
Copy link
Contributor

Closed as solved in HyperFormula v2.5.0
Release notes for the version: https://hyperformula.handsontable.com/guide/release-notes.html#_2-5-0

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Feature Something we can add later on without introducing a breaking change Impact: Low
Projects
None yet
Milestone
No milestone
2 participants
@sequba @AMBudnik