Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use Node 20 in all the build/test workflows #1435

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Jul 18, 2024

Context

  • use node 20 in all the workflows
  • mention node 20 as the recommended version for HyperFormula developers in the docs

How did you test your changes?

  • run all the workflows in the GH environment

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes Run all build scripts in Node Active LTS (currently 20) #1428

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Jul 18, 2024
@sequba sequba linked an issue Jul 18, 2024 that may be closed by this pull request
@sequba sequba merged commit f082027 into develop Jul 18, 2024
15 of 22 checks passed
@sequba sequba deleted the feature/issue-1428 branch July 18, 2024 15:21
Copy link

github-actions bot commented Jul 18, 2024

Performance comparison of head (0361c4e) vs base (df4ddc9)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 515.98 | 504.27 | -2.27%
                                      Sheet B | 165.91 | 166.78 | +0.52%
                                      Sheet T |  149.5 |  144.6 | -3.28%
                                Column ranges | 516.98 | 509.26 | -1.49%
Sheet A:  change value, add/remove row/column |  14.22 |  13.39 | -5.84%
 Sheet B: change value, add/remove row/column | 130.12 | 127.64 | -1.91%
                   Column ranges - add column | 152.33 | 152.99 | +0.43%
                Column ranges - without batch | 470.94 | 438.94 | -6.79%
                        Column ranges - batch | 113.12 | 112.13 | -0.88%

sequba added a commit that referenced this pull request Sep 4, 2024
* Use Node 20 in all the build/test workflows (#1435)

* Update build badge in readme to show the build workflow status instead of test (#1443)

* Update build badge to show the build workflow status instead of test

* Add build-docs workflow (#1434)

* Add build-docs workflow

* Add environment variables necessary to build the docs with Node 20
sequba added a commit that referenced this pull request Nov 6, 2024
* Merge hotfix to develop (#1431)

Change publish-docs workflow to use Node 20 instead of 22 due to the temporary npm issue

* Merge hotfix to develop (#1432)

* Change publish-docs workflow to use Node 20 instead of 22 due to the temporary npm issue (#1424)

* Set NODE_OPTIONS=--openssl-legacy-provider for the typedoc command

* Merge hotfix to develop (#1433)

* Change publish-docs workflow to use Node 20 instead of 22 due to the temporary npm issue (#1424)

* Hotfix: Set NODE_OPTIONS=--openssl-legacy-provider for the typedoc command (#1425)

Set NODE_OPTIONS=--openssl-legacy-provider for the typedoc command

* Revert the publish-docs workflow to Node 16

* Add build-docs workflow (#1434)

* Add build-docs workflow

* Add environment variables necessary to build the docs with Node 20

* Use Node 20 in all the build/test workflows (#1435)

* Remove license comments from the UMD build (#1437)

* Install terser plugin explicite to enable extensive customization

* Remove license comment from the UMD builds using string-replace-loader webpack plugin

* Test for the redundant license comments in the UMD build inside the verify:umd script

* Update build badge in readme to show the build workflow status instead of test (#1443)

* Update build badge to show the build workflow status instead of test

* Native demos in the docs (#1447)

* Add markdown-it plugins

* Make HTML+CSS preview work

* Make some of the buttons work

* Add edit-in-stackblitz button

* Make the entire runtime of the demo work (including js)

* Add real HF demo.

* Make HyperFormula import work in runtime of the docs examples

* Add script code-examples-generator

* Style stackblitz button

* Style demo internal buttons

* Remove unused glue-code

* Remove not needed vuepress plugins

* Fix linter error

* Reformat demo/example1.ts file

* Add advanced-usage demo

* Change the framework demos in the docs to use Codesandbox iframe instead of Stackblitz

* Add basic-operations demo

* Add basic-usage demo

* Add batch-operations demo

* Add demo clipboard-operations

* Changed the custom-functions demo to use Codesandbox instead of Stackblitz

* Add date-time demo

* Add demo i18n

* Add localizing-functions guide

* Add named-expressions demo

* Add sorting-data demo

* Add undo-redo demo

* Fix lint errors

* Disable linter for the docs examples

* Tweak the styling of demo example

* Fix row and column counting in the docs examples

* Adjust css of basic-usage demo

* Adjust style of advanced-usage demo

* Fix styles for basic-operations demo

* Fix styles for batch-operations demo

* Fix styles for sorting demo

* Fix height of the table cell in the demos

* Adjust text decoration of the summary row in the i18n demo

* Fix styles for basic-operations demo

* Adjust styles for the inputs

* Disable logging HF version to console in the native examples embedded in the docs

* Update styles for the open-in-stackblitz button

* Fix broken favicon link

* Fix examples.js script to handle newline characters in both unix and windows styles

* Reduce space between buttons and table in the undo-redo demo

* Fix style for checkbox in the batch-operations demo
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run all build scripts in Node Active LTS (currently 20)
1 participant