Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Describe the limitation of the OFFSET function in the runtime differences guide #1488

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Describe the limitation of the OFFSET function in the runtime differences guide #1488

wants to merge 2 commits into from
+4 −3

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Jan 16, 2025 •
edited
Loading

Context

The implementation of the OFFSET function in HyperFormula has some limitations. The first argument must be a reference to a single cell. Ranges are not allowed.

How did you test your changes?

local docs build

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1477

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Jan 16, 2025
@sequba sequba linked an issue Jan 16, 2025 that may be closed by this pull request
[Bug]: OFFSET formula does not work with ranges #1477
Open
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (f392eae) to head (25eeab0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1488   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14523    14523           
  Branches      3080     3080           
========================================
  Hits         14120    14120           
  Misses         403      403

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Performance comparison of head (25eeab0) vs base (f392eae)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 506.76 | 503.87 | -0.57%
                                      Sheet B | 161.36 |    163 | +1.02%
                                      Sheet T |  142.8 | 143.94 | +0.80%
                                Column ranges | 508.64 | 510.05 | +0.28%
Sheet A:  change value, add/remove row/column |  13.63 |  13.93 | +2.20%
 Sheet B: change value, add/remove row/column | 123.12 |  121.5 | -1.32%
                   Column ranges - add column | 152.79 | 150.54 | -1.47%
                Column ranges - without batch | 428.82 | 438.38 | +2.23%
                        Column ranges - batch | 110.98 | 110.91 | -0.06%

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@sequba sequba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: OFFSET formula does not work with ranges
1 participant
@sequba