Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add option to limit maxParts in multipart payloads #4425

Closed
devinivy opened this issue Feb 14, 2023 · 0 comments
Closed

Add option to limit maxParts in multipart payloads #4425

devinivy opened this issue Feb 14, 2023 · 0 comments
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement security Issue with security impact
Milestone

Comments

@devinivy
Copy link
Member

devinivy commented Feb 14, 2023

We have added the option route.option.payload.maxParts, in order to mitigate a DoS vector caused by an unbounded number of parts permitted in multipart payloads. The value of maxParts controls the maximum number of parts permitted in multipart payloads. The latest version of subtext also makes efforts to clean-up any files written during payload processing in the case of a payload processing error. The breaking change here is that the default value for maxParts is 1000, whereas before it was effectively unbounded.

This has been released in 21.3.0 and backported to 20.3.0.

Credit to @das7pad for the thorough report and disclosure.

@devinivy devinivy added feature New functionality or improvement breaking changes Change that can breaking existing code security Issue with security impact labels Feb 14, 2023
@devinivy devinivy added this to the 21.3.0 milestone Feb 14, 2023
@devinivy devinivy changed the title Add option to limit maxParts in maultipart payloads Add option to limit maxParts in multipart payloads Feb 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement security Issue with security impact
Projects
None yet
Development

No branches or pull requests

1 participant