From cb03cc4c34a320b1e5c28ae0e15b45b1047ac250 Mon Sep 17 00:00:00 2001 From: Joe Lencioni Date: Fri, 31 Jan 2025 13:28:18 -0600 Subject: [PATCH] Improve warning message when failing to fetch CSS If the `block.href` here is a full URL, then the `makeAbsolute` function above will not touch it but that's not super clear with how this warning is written. I'm hoping that this makes it easier to understand what's going on here. --- controller.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controller.js b/controller.js index 871f5b2..2ac19e4 100644 --- a/controller.js +++ b/controller.js @@ -50,7 +50,7 @@ async function downloadCSSContent(blocks) { res = await proxiedFetch(absUrl, { retryCount: 5 }); } catch (e) { console.warn( - `[HAPPO] Failed to fetch CSS file from ${block.href} (using base URL ${block.baseUrl}). This might mean styles are missing in your Happo screenshots`, + `[HAPPO] Failed to fetch CSS file from ${absUrl} (using ${block.href} with base URL ${block.baseUrl}). This might mean styles are missing in your Happo screenshots.`, ); return; }