Skip to content

"expose-fd listeners" advice in README out of date for 2.6 and newer? #13

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
eest opened this issue Mar 16, 2025 · 1 comment
Open
Assignees
Labels

Comments

@eest
Copy link

eest commented Mar 16, 2025

Hello,

Right now the README gives the impression that in order to achieve seamless reloads you need to enable the stats socket and include expose-fd listeners:

To achieve seamless reloads it is required to use expose-fd listeners and socket transfers which are not enabled by default.

However, looking at e.g. https://docs.haproxy.org/2.6/configuration.html#5.1-expose-fd%20listeners it states:

In master-worker mode, this is not required anymore, the listeners will be passed using the internal socketpairs between the master and the workers.

Since all versions of the entrypoint.sh script automatically enables master-worker mode via the -W flag it seems to me that for at least 2.6 and up you actually don't need to have the stats socket enabled at all for seamless reloads to work?

On a similar note the README also stats that you send SIGHUP to reload the configuration, but reading even the older 2.2 version of the docs (https://docs.haproxy.org/2.2/configuration.html#3.1-master-worker) it states:

Using this mode, you can reload HAProxy directly by sending a SIGUSR2 signal to the master.

So maybe the selection of signal should be updated as well?

@dkorunic dkorunic self-assigned this Apr 16, 2025
@dkorunic dkorunic added the bug label Apr 16, 2025
@dkorunic
Copy link
Member

All your points are valid and I can confirm fixing README is in the queue to be done really soon. My apologies for being late on this (and being late with the response), but we are working on a few key projects at the moment..

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants