Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Option for using gtk-theme buttons #10

Closed
ghost opened this issue Sep 27, 2017 · 7 comments
Closed

Option for using gtk-theme buttons #10

ghost opened this issue Sep 27, 2017 · 7 comments

Comments

@ghost
Copy link

ghost commented Sep 27, 2017

First of all, your extension is genius and really needed for the GNOME-Desktop in my opinion. My issue or better enhancement would be, enable the user to use his gtk-theme buttons for the close, min and max buttons. Additionally i would give the option to replace the activity button with window-controls and get the activity button back if no window is maximized. This way the window-title would not move if a window get maximized. All of this adds consistency and would be really awesome.

Please take this with a grain of salt, because i have no experience with GNOME-Shell-extensions and don't really know, if this enhancement is possible. Anyway, thank you for the effort.

@jonian
Copy link
Member

jonian commented Sep 27, 2017

Hi @RockOnHero, thank you for your input.
Window button themes and hiding activity button are in our roadmap. We will also add settings to make them configurable.

@ghost
Copy link
Author

ghost commented Jan 23, 2018

@jonian maybe the roadmap could go in the readme for reference?

@jonian
Copy link
Member

jonian commented Jan 23, 2018

@RockOnHero there is no roadmap with dates. Issues marked as enhancement or feature will be implemented.

@franglais125
Copy link

@jonian In case you might find it useful, I have implemented something similar in my extension (a fork of Pixel Saver). it might serve as guidance or save some time:

franglais125/no-title-bar@1f2c458

@jonian
Copy link
Member

jonian commented Feb 23, 2018

@franglais125 thank you! I have already started implementing this, but I have been busy with work.

https://github.com/hardpixel/unite-shell/blob/master/unite%40hardpixel.eu/settings.ui#L310
https://github.com/hardpixel/unite-shell/blob/master/unite%40hardpixel.eu/schemas/org.gnome.shell.extensions.unite.gschema.xml#L2
https://github.com/hardpixel/unite-shell/blob/master/unite%40hardpixel.eu/prefs.js#L58

@jonian
Copy link
Member

jonian commented Mar 18, 2018

Window button themes are now available in master branch. Included themes:

  • Default Dark
  • Default Light
  • Ambiance
  • Radiance
  • Arc Dark
  • Arc Light
  • United Dark
  • United Light

More themes will be added in the future.

@jonian jonian closed this as completed Mar 18, 2018
@tumb1er
Copy link

tumb1er commented May 8, 2018

@jonian on Ubuntu-18.04 at current master no window button icons appear at all, empty space that works like buttons.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants