Expose fs as an option to override the default implementations
#138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harttle
added a commit
that referenced
this pull request
Jun 27, 2019
harttle
pushed a commit
that referenced
this pull request
Jun 27, 2019
# [8.3.0](v8.2.4...v8.3.0) (2019-06-27) ### Features * fs option implemented by [#138](#138) ([3f5e23c](3f5e23c))
|
🎉 This PR is included in version 8.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #131 , this PR exposes a new
fsoption that allows to change how files are read from the file-system. Thefsmodule is used while rendering "partials" and "includes" and also when callingengine.renderFile().The option is optional. When omitted, the engine follows the current behavior of loading via the native
fsmodule (Node.js) or via an AJAX request (browser).Overriding the
fsoption can be used for specific use cases. Examples:Closes #131
Feedback appreciated 🙇