Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add eth_blockNumber acceptance test #217

Closed
Tracked by #188
Nana-EC opened this issue Jun 16, 2022 · 0 comments · Fixed by #233
Closed
Tracked by #188

Add eth_blockNumber acceptance test #217

Nana-EC opened this issue Jun 16, 2022 · 0 comments · Fixed by #233
Assignees
@Ivo-Yankov
Labels
enhancement New feature or request P1 process Build, test and deployment-process related tasks
Milestone
0.2.0

Comments

@Nana-EC
Copy link
Collaborator

Nana-EC commented Jun 16, 2022 •
edited
Loading

Problem

No test exists to confirm eth_blockNumber and its return

Solution

Add an acceptance test that asserts the returned response from eth_blockNumber is valid and is an integer.

Alternatives

Add as an acceptance test in eth.spec.ts
@Nana-EC Nana-EC added enhancement New feature or request P2 labels Jun 16, 2022
@Nana-EC Nana-EC added this to the 0.2.0 milestone Jun 16, 2022
@Nana-EC Nana-EC changed the title Add eth_blockNumber data type return test Add eth_blockNumber acceptance test Jun 16, 2022
@Nana-EC Nana-EC added P1 process Build, test and deployment-process related tasks and removed P2 labels Jun 16, 2022
@Nana-EC Nana-EC mentioned this issue Jun 16, 2022
Closed
19 tasks
@Ivo-Yankov Ivo-Yankov linked a pull request Jun 20, 2022 that will close this issue
Acceptance test plan #233
Merged
2 tasks
@Nana-EC Nana-EC mentioned this issue Jun 20, 2022
Merged
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Ivo-Yankov Ivo-Yankov

Labels
enhancement New feature or request P1 process Build, test and deployment-process related tasks
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Acceptance test plan hashgraph/hedera-json-rpc-relay
2 participants
@Ivo-Yankov @Nana-EC