Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add additional eth_getBlockByNumber acceptance tests #222

Closed
4 tasks done
Tracked by #188
Nana-EC opened this issue Jun 16, 2022 · 0 comments · Fixed by #233
Closed
4 tasks done
Tracked by #188

Add additional eth_getBlockByNumber acceptance tests #222

Nana-EC opened this issue Jun 16, 2022 · 0 comments · Fixed by #233
Assignees
Labels
enhancement New feature or request P2 process Build, test and deployment-process related tasks
Milestone

Comments

@Nana-EC
Copy link
Collaborator

Nana-EC commented Jun 16, 2022

Problem

The initial eth_getBlockByNumber coverage was scarce

Solution

Add move coverage

  • Enhance the already existing getBlockByNumber test by adding assertion of the returned object that it has transactions array containing the full transaction and not only the string of their hash (testing the "hydrated transactions flag")
  • Add a test that queries existing block by number but sets hydrated transactions to **false**. Assert that the response contains transactions` array but the values are strings of the transaction hash
  • Add negative test for non-existing block number with hydrated transactions set to **true**. The response of the call must be asserted to be:
{
  "jsonrpc": "2.0",
  "id": 0,
  "result": null
}
  • Add negative test for non-existing block number with hydrated transactions set to **false**. The response of the call must be asserted to be:
{
  "jsonrpc": "2.0",
  "id": 0,
  "result": null
}

Alternatives

No response

@Nana-EC Nana-EC added enhancement New feature or request P2 process Build, test and deployment-process related tasks labels Jun 16, 2022
@Nana-EC Nana-EC added this to the 0.2.0 milestone Jun 16, 2022
@Ivo-Yankov Ivo-Yankov linked a pull request Jun 20, 2022 that will close this issue
2 tasks
@Nana-EC Nana-EC mentioned this issue Jun 20, 2022
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request P2 process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants