ingress-gateways: don't log error when registering gateway #15001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when an ingress gateway was registered without a corresponding ingress gateway config entry, an error was logged because the watch on the config entry returned a nil result. This is expected so don't log an error.
lkysow
force-pushed
the
lkysow/igw-logging-err
branch
from
8c95237 to
f9667eb
Compare
lkysow
commented
Oct 16, 2022
| @@ -91,6 +91,9 @@ func (s *handlerIngressGateway) handleUpdate(ctx context.Context, u UpdateEvent, | |||
| if !ok { | |||
| return fmt.Errorf("invalid type for response: %T", u.Result) | |||
| } | |||
There was a problem hiding this comment.
The fix is to guard on resp.Entry being nil. One thing this doesn't handle is if the config entry is deleted. If it's deleted, I think the expectation would be that everything is reset back to the baseline. This can be done in a different PR though and likely isn't worth it if the api gateway work is completed.
ishustava
approved these changes
Oct 25, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when an ingress gateway was registered without a corresponding ingress gateway config entry, an error was logged because the watch on the config entry returned a nil result. This is expected since the first call to watch will return a nil entry so don't log an error.
Fixes #11719
Error that used to be logged:
agent.proxycfg: Failed to handle update from watch: service_id=ingress-gateway id=gateway-config error="invalid type for config entry: <nil>"PR Checklist