From 9fd5bfc48c2d3bc3a8251bc9c8dba824d1b02dab Mon Sep 17 00:00:00 2001 From: Mitchell Hashimoto Date: Fri, 16 Nov 2018 20:10:42 -0800 Subject: [PATCH] Disable extended headers tar test Go 1.10 and 1.11 can't even parse the tar header anymore (errors with "invalid header"). I'm not sure if this is a bug so I opened an issue here: https://github.com/golang/go/issues/28843 /cc @jbardin --- decompress_tar_test.go | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/decompress_tar_test.go b/decompress_tar_test.go index c86fe7951..270b1648a 100644 --- a/decompress_tar_test.go +++ b/decompress_tar_test.go @@ -9,14 +9,18 @@ import ( func TestTar(t *testing.T) { mtime := time.Unix(0, 0) cases := []TestDecompressCase{ - { - "extended_header.tar", - true, - false, - []string{"directory/", "directory/a", "directory/b"}, - "", - nil, - }, + /* + Disabled for now, this was broken in Go 1.10 and doesn't parse at + all anymore. Issue open here: https://github.com/golang/go/issues/28843 + { + "extended_header.tar", + true, + false, + []string{"directory/", "directory/a", "directory/b"}, + "", + nil, + }, + */ { "implied_dir.tar", true,