Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add core property for setting quiet. #121

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Add core property for setting quiet. #121

merged 2 commits into from
Jun 24, 2024

Conversation

dadgar
Copy link
Collaborator

@dadgar dadgar commented Jun 22, 2024

Changes proposed in this PR:

Add a property to disable prompting. This is useful when scripting using HCP.

How I've tested this PR:

I set the property and ran a command that outputs additional output. When set to true, the output was omitted and when false or unset the help output was shown.

Also checked that the hcp profile set --help output shows the new property.

$ echo -n "test" | hcp vs secrets create quiet_test --data-file=-
Secret Name   Latest Version   Created At
quiet_test   1                2024-06-21T23:55:39.442Z

✓ Successfully created secret with name "quiet_test"

To read your secret, run:
  $ hcp vault-secrets secrets read quiet_test6 --app cli

$ hcp profile set core/quiet true
✓ Property "core/quiet" updated

$ echo -n "t" | hcp vs secrets create quiet_test2 --data-file=-
Secret Name   Latest Version   Created At
quiet_test2   1                2024-06-21T23:55:51.291Z

How I expect reviewers to test this PR:

Code review.

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

dadgar added 2 commits June 21, 2024 16:58
Add a property to disable prompting. This is useful when scripting using
HCP.
@dadgar dadgar requested a review from jasonpilz June 22, 2024 00:03
@dadgar dadgar marked this pull request as ready for review June 22, 2024 00:03
@dadgar dadgar requested a review from a team as a code owner June 22, 2024 00:03
@dadgar dadgar merged commit 50168de into main Jun 24, 2024
6 checks passed
@dadgar dadgar deleted the f-quiet branch June 24, 2024 18:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants