Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

store credentials in file for gateway create #135

Merged
merged 4 commits into from
Jul 25, 2024
Merged

store credentials in file for gateway create #135

merged 4 commits into from
Jul 25, 2024

Conversation

hghaf099
Copy link
Contributor

@hghaf099 hghaf099 commented Jul 24, 2024 •
edited
Loading

Changes proposed in this PR:

https://hashicorp.atlassian.net/browse/VAULT-29208

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@hghaf099 hghaf099 requested a review from a team as a code owner July 24, 2024 20:08
@hghaf099 hghaf099 requested a review from ncabatoff July 24, 2024 20:16
@hghaf099 hghaf099 requested a review from ncabatoff July 25, 2024 15:02
@hghaf099 hghaf099 merged commit 40546ea into main Jul 25, 2024
6 checks passed
@hghaf099 hghaf099 deleted the create-gateway-should-print-client-id-secret branch July 25, 2024 15:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hghaf099 @ncabatoff