Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make execution mode configurable Waypoint resources #163

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

paladin-devops
Copy link
Contributor

@paladin-devops paladin-devops commented Sep 20, 2024

Changes proposed in this PR:

The new flags added in this PR enable configurability of a Terraform workspace's execution mode setting for templates and add-on definitions.

How I've tested this PR:

Tests have been added to the happy path test case for each command to ensure the value set is read.

How I expect reviewers to test this PR:

Attempt to create Waypoint templates and add-on definitions with these new configuration settings.

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

@paladin-devops paladin-devops self-assigned this Sep 20, 2024
@paladin-devops paladin-devops marked this pull request as ready for review September 20, 2024 14:29
@paladin-devops paladin-devops requested a review from a team as a code owner September 20, 2024 14:29
@paladin-devops paladin-devops mentioned this pull request Oct 2, 2024
@paladin-devops paladin-devops force-pushed the waypoint-execution-mode branch 2 times, most recently from b0e9ef9 to 9d5f31b Compare October 3, 2024 18:47
The new flags added in this commit enable configurability of a Terraform workspace's execution mode setting for templates and add-on definitions.
@paladin-devops paladin-devops force-pushed the waypoint-execution-mode branch from 9d5f31b to e3b0d39 Compare October 3, 2024 18:57
Copy link
Contributor

@HenryEstberg HenryEstberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paladin-devops paladin-devops changed the base branch from main to f-waypoint-improvements October 4, 2024 17:47
@paladin-devops paladin-devops merged commit 7341b89 into f-waypoint-improvements Oct 4, 2024
6 checks passed
@paladin-devops paladin-devops deleted the waypoint-execution-mode branch October 4, 2024 17:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants