Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add update group command #41

Merged
merged 7 commits into from
Mar 23, 2024
Merged

Add update group command #41

merged 7 commits into from
Mar 23, 2024

Conversation

dadgar
Copy link
Collaborator

@dadgar dadgar commented Mar 20, 2024

Changes proposed in this PR:

Add hcp iam groups update command.

How I've tested this PR:

$ hcp iam groups create cli-test --description "cli-test"
Resource Name: iam/organization/11eb5071-5393-1932-a04c-0242ac110014/group/cli-test
Resource ID:   iam.group:gJBqc6FHfzDJhHczPNTc
Display Name:  cli-test
Member Count:  0
Description:   cli-test

$ hcp iam groups update cli-test
ERROR: either display name or description must be specified

$ hcp iam groups update cli-test --display-name "updated-name" --description "updated test"
✓ Group "iam/organization/11eb5071-5393-1932-a04c-0242ac110014/group/cli-test" updated

$ hcp iam groups read cli-test
Resource Name: iam/organization/11eb5071-5393-1932-a04c-0242ac110014/group/cli-test
Resource ID:   iam.group:gJBqc6FHfzDJhHczPNTc
Display Name:  updated-name
Member Count:  0
Description:   updated test

$ hcp iam groups delete cli-test
The group will be deleted.

Do you want to continue (y/n)? y

✓ Group "iam/organization/11eb5071-5393-1932-a04c-0242ac110014/group/cli-test" deleted

How I expect reviewers to test this PR:

Check the update command covers all updatable fields, and has good documentation.

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@dadgar dadgar changed the title F group updates Add update group command Mar 21, 2024
@dadgar dadgar requested a review from squaresurf March 21, 2024 00:13
@dadgar dadgar marked this pull request as ready for review March 21, 2024 00:13
Copy link

@squaresurf squaresurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! 🙌

@dadgar dadgar merged commit 85e39b0 into main Mar 23, 2024
5 checks passed
@dadgar dadgar deleted the f-group-updates branch March 23, 2024 00:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants