Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow more profile commands to be run while unauthenticated #47

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

dadgar
Copy link
Collaborator

@dadgar dadgar commented Mar 26, 2024

Changes proposed in this PR:

Some of the profile/profiles commands required the CLI to be authenticated unnecessarily. This fixes that and makes authentication optional for profile set when validating the org/project_id.

How I've tested this PR:

Ran hcp auth logout and then used the hcp profile commands.

How I expect reviewers to test this PR:

Code review

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

Some of the profile/profiles commands required the CLI to be
authenticated unnecessarily. This fixes that and makes authentication
optional for `profile set` when validating the org/project_id.
@dadgar dadgar requested a review from tobias-hashicorp March 26, 2024 00:48
Copy link
Contributor

@tobias-hashicorp tobias-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


I am using Feedback Ladder annotations to make the importance/urgency of comments easier to understand.

Emoji Name Importance/Urgency
🏔 Mountain This change should not go live. Back to the drawing board.
🧗🏻‍♂️ Boulder Has to be addressed before this can be merged.
⚪️ Pebble Needs to be addressed. Can be in a future PR.
Sand Needs to be considered. Can be in a future PR.
✏️ Pen Typo or grammatical error. Can be addressed in a future PR.
💨 Dust "Take it or Leave it"

internal/pkg/auth/auth.go Outdated Show resolved Hide resolved
Co-authored-by: Tobias <54770321+tobias-hashicorp@users.noreply.github.com>
@dadgar dadgar merged commit d7c3151 into main Mar 26, 2024
4 checks passed
@dadgar dadgar deleted the f-profile-auth branch March 26, 2024 22:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants