Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Updates apis that referenced ActionConfigID to ActionRunID #57

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Updates apis that referenced ActionConfigID to ActionRunID #57

merged 2 commits into from
Apr 17, 2024

Conversation

evanphx
Copy link
Contributor

@evanphx evanphx commented Apr 16, 2024 •
edited
Loading

Changes proposed in this PR:

The API changed a field from being named ActionConfigId to ActionRunId.

How I've tested this PR:

Running the agent and seeing the value being used.

How I expect reviewers to test this PR:

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@evanphx evanphx requested a review from a team as a code owner April 16, 2024 22:36
@evanphx evanphx force-pushed the f-wp-agent-actions-fix branch from cc5fadf to 6f5c9c0 Compare April 16, 2024 22:58
@evanphx evanphx force-pushed the f-wp-agent-actions-fix branch from 6f5c9c0 to bca9d09 Compare April 16, 2024 23:07
briancain
briancain approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏃🏻🏁

@evanphx evanphx merged commit d7d289c into main Apr 17, 2024
6 checks passed
@evanphx evanphx deleted the f-wp-agent-actions-fix branch April 17, 2024 16:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@briancain briancain briancain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanphx @briancain