[WAYP-2571] TFC Config error #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill not return an error but the TFC config will be nil
briancain
requested changes
May 8, 2024
catsby
approved these changes
May 9, 2024
briancain
approved these changes
May 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This is a small bugfix to return a better error message when a user attempts to read a Waypoint TFC Config and one has not been set.
How I've tested this PR:
This has been manually tested and the acceptance tests have been run.
How I expect reviewers to test this PR:
Run
make go/testto run the acceptance testsTo manually test, build the binary and connect to your HCP org. If that org already has a TFC Config set for waypoint, first run:
To test the change, run:
Output of affected commands:
-->