Fixup: Rename -application-name to just -app for consistency #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other HCP commands use -app for the app name, and it's much less typing than -application-name. This simplifies this flag value.
codergs
reviewed
May 17, 2024
| @@ -58,8 +58,8 @@ $ hcp waypoint add-ons create -n=my-addon -a=my-application -d=my-addon-definiti | |||
| Required: true, | |||
| }, | |||
| { | |||
| Name: "application-name", | |||
| DisplayValue: "NAME", | |||
| Name: "app", | |||
There was a problem hiding this comment.
I wonder since this is a breaking change, how about we add both into the mix for some period of time, and then let users drift away. Not sure if it is possible, but when specified both could update the same underlying var.
There was a problem hiding this comment.
I don't feel like that's worth the maintenance effort. Maybe if this CLI had been around for years sure, but at this point it's brand new (not to mention Waypoint is still in beta) so I'd rather make the breaking change than maintain two flags for backwards compatibility right now. I do appreciate the suggestion though!
codergs
approved these changes
May 17, 2024
paladin-devops
approved these changes
May 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Other HCP commands use -app for the app name, and it's much less typing than -application-name. This simplifies this flag value.
How I've tested this PR:
Built and validated the flag name changed, updated the tests and saw they passed.
How I expect reviewers to test this PR:
Same ☝🏻
Checklist: