Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

UI: decode unicode properly in log page #7470

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

kybin
Copy link
Contributor

@kybin kybin commented Mar 24, 2020

unicode logs in log page are not showing properly currently.

with a little research I found this.

https://stackoverflow.com/a/30106551/1932530

I checked it and for me it works, please confirm.

@DingoEatingFuzz
Copy link
Contributor

Hi @kybin, thank you for your contribution! I tested this out and I am happy to merge it.

I do want to give you a heads up, however. As part of the Exec UI (#6697), we added a proper third-party text encoding library. I plan on updating this log streaming code to use the same library which will replace what you have added here. But your contribution will forever be in the git log!

@DingoEatingFuzz DingoEatingFuzz merged commit b3a23c9 into hashicorp:master Mar 30, 2020
@kybin
Copy link
Contributor Author

kybin commented Mar 31, 2020

@DingoEatingFuzz Thank you for your consideration and explanation. I agree that handling with a complete library will be a better option. :)

notnoop pushed a commit that referenced this pull request Apr 9, 2020
UI: decode unicode properly in log page
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants