Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for metadata functions -json command #358

Merged
merged 6 commits into from
Feb 15, 2023
Merged

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Feb 7, 2023

This PR adds support for the new terraform metadata functions -json command, which was introduced in hashicorp/terraform#32487. We need this to obtain the function signatures within terraform-ls.

Depends on:

TODO

@radeksimko radeksimko changed the title Add support for metadata functions -json command, Add support for metadata functions -json command Feb 8, 2023
@dbanck dbanck force-pushed the f-metadata-functions branch from 82a097e to 252f514 Compare February 8, 2023 14:41
Relative paths in the go.work file are likely machine specific and
won't work on other systems.
@dbanck dbanck force-pushed the f-metadata-functions branch from 252f514 to d449928 Compare February 13, 2023 10:20
@dbanck dbanck marked this pull request as ready for review February 14, 2023 17:58
@dbanck dbanck requested review from radeksimko and kmoe February 14, 2023 18:00
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that the output is coming through in the E2E test: https://github.com/hashicorp/terraform-exec/actions/runs/4176231939/jobs/7232437983#step:4:913

👍🏻 LGTM :shipit:

tfexec/metadata_functions.go Outdated Show resolved Hide resolved
dbanck and others added 2 commits February 15, 2023 18:55
Co-authored-by: Radek Simko <radek.simko@gmail.com>
@dbanck dbanck merged commit 0fb01be into main Feb 15, 2023
@dbanck dbanck deleted the f-metadata-functions branch February 15, 2023 19:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants