Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

implement Refresh #53

Merged
merged 1 commit into from
Aug 17, 2020
Merged

implement Refresh #53

merged 1 commit into from
Aug 17, 2020

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Aug 16, 2020

Implement terraform refresh and all opts.

@kmoe kmoe requested review from radeksimko and paultyng August 16, 2020 15:22
@kmoe kmoe mentioned this pull request Aug 16, 2020
Merged
paultyng
paultyng approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we should setup a fixture with http that hits some well known JSON API (ie. releases.hashicorp.com or something) to have some tests that communicate externally?

@kmoe kmoe merged commit fbdfd34 into master Aug 17, 2020
@kmoe kmoe deleted the refresh branch August 17, 2020 16:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@paultyng paultyng paultyng approved these changes

@radeksimko radeksimko Awaiting requested review from radeksimko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmoe @paultyng