Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

knownvalue: Add Int32Exact and Float32Exact checks #356

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Jun 26, 2024

Relates: hashicorp/terraform-plugin-framework#1010
Relates: hashicorp/terraform-plugin-framework#1014

Adds Int32Exact and Float32Exact checks to the knownvalue package for Int32 and Float32 value testing respectively.

@SBGoods SBGoods requested a review from a team as a code owner June 26, 2024 20:27
@SBGoods SBGoods added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 26, 2024
@SBGoods SBGoods added this to the v1.9.0 milestone Jun 26, 2024
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, lgtm! 🚀

@SBGoods SBGoods merged commit ac2ce0a into main Jul 1, 2024
33 checks passed
@SBGoods SBGoods deleted the SBGoods/int32-float32-knownvalue branch July 1, 2024 16:57
austinvalle pushed a commit that referenced this pull request Jul 10, 2024
* Add `float32exact` and `int32exact` types

* Update website documentation

* Add changelog entries

* Update changelog wording
austinvalle pushed a commit that referenced this pull request Jul 10, 2024
* Add `float32exact` and `int32exact` types

* Update website documentation

* Add changelog entries

* Update changelog wording
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants