Skip to content

Switch (Most) Acceptance Testing from resource.Test() to resource.ParallelTest() #5874

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
1 of 3 tasks
bflad opened this issue Sep 13, 2018 · 1 comment
Closed
1 of 3 tasks
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Comments

@bflad
Copy link
Contributor

bflad commented Sep 13, 2018

Description

An upstream pull request (hashicorp/terraform#18688) has been merged that adds a wrapper function for helper/resource.Test() that calls t.Parallel() to enable Go's native testing parallelism (via the go test -parallelism flag). This will greatly help speed up local acceptance testing and CI testing outside TeamCity. It will be released upstream with Terraform 0.11.9.

  • Update dependency: hashicorp/terraform@v0.11.9 (when released)
  • Switch a subset of acceptance tests, e.g. TestAccAWSDBInstance and verify all is well locally and on TeamCity
  • Update rest of the acceptance tests except those that must serialized, which includes:
  • TestAccAWSCloudTrail
  • TestAccAWSConfig
  • TestAccAWSGuardDuty
  • TestAccAWSIAMAccountAlias
  • TestAccAWSOrganizations
  • TestAccAWSSNSSMSPreferences
  • TestAccAWSSpotDatafeedSubscription
  • TestAccAWSWafRegexMatchSet
  • TestAccAWSWafRegexPatternSet
  • TestAccAWSWafRegionalRegexMatchSet
  • TestAccAWSWafRegionalRegexPatternSet
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. labels Sep 13, 2018
@bflad bflad self-assigned this Sep 13, 2018
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

No branches or pull requests

1 participant