Make reboot on extraConfig change optional

[sofixa]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently any extra_config change on a vsphere_virtual_machine resource results in a reboot (even if reboot_required is false , #1004 ). For one of the most common use cases of extra_config, setting guestinfo variables available to the OS, that's not required. I agree that in some cases it might be, so i propose to make it optional with a flag (following VMware's logic of hot adding resources - they can't know if the OS will handle adding RAM or CPUs gracefully, so one needs to explicitly allow it without requiring a reboot). I can implement this myself, it'd be a pretty easy change. Maybe we can keep it to reboot_required =true by default to keep up with the current behaviour, but allow changing it to facilitate use.

Potential Terraform Configuration

resource "vsphere_virtual_machine" "pa3_nomad_01" {
  provider                   = vsphere.pa3
  name                       = "pa3-client-01b"
  datastore_id               = data.vsphere_datastore.pa3_datastore_08.id
  resource_pool_id           = data.vsphere_compute_cluster.pa3_compute_cluster.resource_pool_id

  cpu_hot_add_enabled    = true
  memory_hot_add_enabled = true
  num_cpus               = "2"
  memory                 = 4096
  extra_config_reboot_required = False

  extra_config = {
    "guestinfo.vmname" = "pa3-client-01b"
  }
}

[sofixa]

@bill-rich any news on this? Would you be open to accepting such a change? If yes, i can work on it ~next week.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.