tags: Support tagging in datastore resources #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update supports tagging in the vsphere_nas_datastore and vsphere_vmfs_datastore resources. Using the same workflows applied to the virtual machine resource. In addition to the tests supplied for the datastore resources, I've re-enabled the import test for vsphere_vmfs_datastore now that we have ImportStateIdFunc to help generate the ID.
vancluever
force-pushed
the
f-tag-datastores
branch
from
756f3e6 to
76c3e13
Compare
Fixing small typo.
mbfrahry
approved these changes
Sep 25, 2017
| @@ -113,11 +131,26 @@ func resourceVSphereNasDatastoreRead(d *schema.ResourceData, meta interface{}) e | |||
| return err | |||
| } | |||
|
|
|||
| // Read tags if we have the ability to do so | |||
| if tagsClient, _ := meta.(*VSphereClient).TagsClient(); tagsClient != nil { | |||
| if err := readTagsForResoruce(tagsClient, ds, d); err != nil { | |||
| @@ -197,11 +216,26 @@ func resourceVSphereVmfsDatastoreRead(d *schema.ResourceData, meta interface{}) | |||
| return err | |||
| } | |||
|
|
|||
| // Read tags if we have the ability to do so | |||
| if tagsClient, _ := meta.(*VSphereClient).TagsClient(); tagsClient != nil { | |||
| if err := readTagsForResoruce(tagsClient, ds, d); err != nil { | |||
|
Thanks @mbfrahry! Merging now |
ghost
locked and limited conversation to collaborators
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update supports tagging in the
vsphere_nas_datastoreandvsphere_vmfs_datastoreresources. Using the same workflows applied tothe virtual machine resource.
In addition to the tests supplied for the datastore resources, I've
re-enabled the import test for
vsphere_vmfs_datastorenow that we haveImportStateIdFuncto help generate the ID.