New resource: vsphere_distributed_virtual_switch (refactor) #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a major refactor of the DVS resource provided in PR #135. More options have been added, the DVS has been fixed so that it uses the VMware DVS object instead of the generic DVS object, which is more or less just used for 3rd party DVS switches. This meant that the DVS was missing a number of features that more than likely would have been expected in the DVS. The breadth of the features added can be seen in the documentation. It should be noted that this does not include the ability to set private VLANs, filtering policies, or port mirroring sessions, which will be added at a later date and pending business case. This work also contains a bunch of up front work that will be necessary for the vsphere_distributed_port_group resource, which will be following not too long after this resource.
vancluever
added
enhancement
vancluever
added a commit
that referenced
this pull request
Oct 9, 2017
This commit adds the vsphere_distributed_port_group resource, allowing port groups to be created on DVS switches, introducing the ability to manage real networks with Terraform that can be used to set up virtual machines on. This update also includes various fixes to #188 to fix spurious diffs and expected behaviour when both resources are used in tandem.
|
Thanks @mbfrahry! |
vancluever
added a commit
that referenced
this pull request
Oct 10, 2017
This commit adds the vsphere_distributed_port_group resource, allowing port groups to be created on DVS switches, introducing the ability to manage real networks with Terraform that can be used to set up virtual machines on. This update also includes various fixes to #188 to fix spurious diffs and expected behaviour when both resources are used in tandem.
ghost
locked and limited conversation to collaborators
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is a major refactor of the DVS resource provided in PR #135.
More options have been added, the DVS has been fixed so that it uses the
VMware DVS object instead of the generic DVS object, which is more or
less just used for 3rd party DVS switches. This meant that the DVS was
missing a number of features that more than likely would have been
expected in the DVS.
The breadth of the features added can be seen in the documentation. It
should be noted that this does not include the ability to set private
VLANs, filtering policies, or port mirroring sessions, which will be
added at a later date and pending business case.
This work also contains a bunch of up front work that will be necessary
for the
vsphere_distributed_port_groupresource, which will be followingnot too long after this resource.