Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

r/virtual_machine: Network allocation settings require vSphere >= 6.0 #322

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

vancluever
Copy link
Contributor

These are not default settings so this only comes up if you try to set
them, but they should be restricted anyway. Oddly they are settable on
vCenter 5.5 update 3f, and the settings take, but they do not seem to be
visible in the MOB. The docs say that the settings are not available
until vSphere 6 anyway.

Fixes #286.

These are not default settings so this only comes up if you try to set
them, but they should be restricted anyway. Oddly they are settable on
vCenter 5.5 update 3f, and the settings take, but they do not seem to be
visible in the MOB. The docs say that the settings are not available
until vSphere 6 anyway.

Fixes #286.
@vancluever vancluever added the bug Type: Bug label Dec 14, 2017
@vancluever
Copy link
Contributor Author

Smoke tested on our secondary vSphere 5.5 lab. We also have a test that does set resource allocation settings which still passes on 6.5:

=== RUN   TestAccResourceVSphereVirtualMachine/multi-device
    --- PASS: TestAccResourceVSphereVirtualMachine (174.59s)
    --- PASS: TestAccResourceVSphereVirtualMachine/multi-device (174.59s)

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vancluever vancluever merged commit 2de7503 into master Dec 14, 2017
@vancluever vancluever deleted the b-restrict-netif-resource-55 branch January 18, 2018 05:37
@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential backwards compatibility issues with vSphere 5.5
2 participants